Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better cross platform spawn #5

Merged
merged 3 commits into from Oct 9, 2019
Merged

Better cross platform spawn #5

merged 3 commits into from Oct 9, 2019

Conversation

stramel
Copy link
Contributor

@stramel stramel commented Oct 4, 2019 •
edited

We have ran into issues with spawning in Windows on TravisCI. (TanStack/table#1559)

In these changes I have:

  • Installed cross-spawn for a better cross-platform spawning solution
  • Make the process fail loudly for errors that try to fail silently
  • Bumped the is-ci version (Drops the no longer supported Node versions)
  • Bumped the minimum Node version to 8 (Required by cross-spawn and is-ci)
  • Prevent generation of and ignore lock files

@stramel stramel mentioned this pull request Oct 4, 2019
Merged
YellowKirby
YellowKirby reviewed Oct 8, 2019
View reviewed changes
Copy link
Owner

@YellowKirby YellowKirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Just have a couple questions, but this looks good 👍

.npmrc Show resolved Hide resolved
cli.js Outdated Show resolved Hide resolved
@stramel
Copy link
Contributor Author

stramel commented Oct 9, 2019

Should be good to go @YellowKirby. Thanks for the quick reviews!

@YellowKirby YellowKirby merged commit 2b60428 into YellowKirby:master Oct 9, 2019
@stramel stramel deleted the ms/updates branch October 9, 2019 16:41
@YellowKirby
Copy link
Owner

Thanks again! Just published this as 2.0.0: https://github.com/YellowKirby/is-ci-cli/releases/tag/v2.0.0

@ChristianMurphy ChristianMurphy mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YellowKirby YellowKirby YellowKirby left review comments

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stramel @YellowKirby @ChristianMurphy