Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Node 20 #19884

Closed
wants to merge 3 commits into from
Closed

Added support for Node 20 #19884

wants to merge 3 commits into from

Commits on Apr 18, 2024

  1. Fixed test on Node 20 

    refs TryGhost/gscan@f39d1d3

- similar to the commit above, the JSON parser changed between Node 18
  and Node 20, so the error message changed too
- we actually just want to check the error is forwarded to the user, so
  we can do that by getting the error message from JSON.parse and check
  against that
    @daniellockyer
    daniellockyer committed Apr 18, 2024
    Copy the full SHA
    c40713b View commit details
    Browse the repository at this point in the history

  2. ℹ️ Added support for Node 20 

    ref https://linear.app/tryghost/issue/ENG-765/add-support-for-node-20

- this adds support for Node 20 to Ghost and CI, as Node 20 is an LTS
  version and we should pick it up
    @daniellockyer
    daniellockyer committed Apr 18, 2024
    Copy the full SHA
    682a770 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into node-20

    @daniellockyer
    daniellockyer committed Apr 18, 2024
    Copy the full SHA
    f5821bf View commit details
    Browse the repository at this point in the history