Added support for Node 20 #19884
Closed
Added support for Node 20 #19884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellockyer
force-pushed
the
node-20
branch
2 times, most recently
from
dd55b6b
to
0558f9d
Compare
refs TryGhost/gscan@f39d1d3 - similar to the commit above, the JSON parser changed between Node 18 and Node 20, so the error message changed too - we actually just want to check the error is forwarded to the user, so we can do that by getting the error message from JSON.parse and check against that
ref https://linear.app/tryghost/issue/ENG-765/add-support-for-node-20 - this adds support for Node 20 to Ghost and CI, as Node 20 is an LTS version and we should pick it up
auto-merge was automatically disabled
April 18, 2024 11:15
Rebase failed
|
Merged in 10e81ae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/tryghost/issue/ENG-765/add-support-for-node-20