Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Typescript 5.0 #2201

Closed
nandi95 opened this issue Mar 16, 2023 · 4 comments
Closed

Allow Typescript 5.0 #2201

nandi95 opened this issue Mar 16, 2023 · 4 comments
Labels
enhancement Improved functionality

Comments

@nandi95
Copy link

nandi95 commented Mar 16, 2023

Search Terms

typescript 5.0

Problem

Typescript 5.0 released but the peer dependencies do not allow v5 yet.

Suggested Solution

Allow 5.0.x in the peer dependencies.

If also updating the package to v5 this is a relevant flag to the project verbatimModuleSyntax and it's connection to isolatedModules
An alternative option for imports could be to setup ts lint and use @typescript-eslint/consistent-type-imports

I had a quick attempt at updating but ended up with 2 errors in tests
evals to false:

equal(rFoo.flags.isReadonly, true);

I suspect here it failes a deep equality check:
getConverter2Program();

@nandi95 nandi95 added the enhancement Improved functionality label Mar 16, 2023
@LoboMetalurgico
Copy link

Yes, please

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Mar 17, 2023

Will probably be Sunday, don't expect I'll have time before then

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Mar 19, 2023

Support released in 0.23.28

@Gerrit0 Gerrit0 closed this as completed Mar 19, 2023
@skjnldsv
Copy link

🎉 🙏 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved functionality
Projects
None yet
Development

No branches or pull requests

4 participants