Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node 20, and drop support for Node 16 #466

Merged
merged 11 commits into from Apr 26, 2023

Conversation

Half-Shot
Copy link
Contributor

As per https://github.com/nodejs/release#release-schedule, Node 20 has now been released and we will start testing for it. Node 16 is in maintenance and will no longer be supported. Node 18 is the last version we will support.

Copy link
Contributor

@justinbot justinbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but looks good (looks like CI will be fixed by upgrading matrix-appservice after matrix-org/matrix-appservice-node#65)

package.json Outdated Show resolved Hide resolved
@AndrewFerr
Copy link
Member

Is now a good time to replace the npm commands in package.json (and docs files) with their yarn equivalents?

@AndrewFerr
Copy link
Member

The dependencies of the two example modules (under ./examples) may as well be updated too. It turns out their lockfiles were quite out of whack, too. If it's welcomed, I prepared a commit to fix those issues that could be pushed here.

@Half-Shot
Copy link
Contributor Author

The dependencies of the two example modules (under ./examples) may as well be updated too. It turns out their lockfiles were quite out of whack, too. If it's welcomed, I prepared a commit to fix those issues that could be pushed here.

Feel free, though longer term we need to sort out those examples. I think we always forget about them and CI don't care :p.

Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the glibc compat issues resolved, this is finally done 😃

@Half-Shot Half-Shot merged commit d5ab312 into develop Apr 26, 2023
6 checks passed
@Half-Shot Half-Shot deleted the hs/add-node-20-drop-16 branch May 2, 2023 16:07
enekonieto added a commit to enekonieto/matrix-appservice-bridge that referenced this pull request May 6, 2023
Support for node 16 has been dropped in matrix-org#466
AndrewFerr pushed a commit that referenced this pull request May 16, 2023
* Update required Node version to 18 in README.md

Support for node 16 has been dropped in #466

* Signed-off-by: Eneko Nieto <eneko@eneko.ovh>

* Update 470.doc

---------

Co-authored-by: Will Hunt <will@half-shot.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants