Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): expose public interfaces from root index.d.ts #790

Merged

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 8, 2018

this tweaks #788 by exposing proper public types API from root index.d.ts so consumer doesn't have to traverse private package path to access interfaces.

before

// @ts-check
const tsLoaderOptionsRules = /** @type {import('ts-loader/dist/types/interfaces').LoaderOptions}*/ ({
  configFile: tsConfig,
  transpileOnly: true
})

after

// @ts-check
const tsLoaderOptionsRules = /** @type {import('ts-loader').Options}*/ ({
  configFile: tsConfig,
  transpileOnly: true
})

@johnnyreilly
Copy link
Member

Great - thanks! Will try and push this out soon. I appreciate your work ♥️🌻

@johnnyreilly johnnyreilly merged commit 3a61d4b into TypeStrong:master Jun 8, 2018
@Hotell Hotell deleted the mh/tweak-public-ambient-types-api branch June 8, 2018 19:36
@Hotell
Copy link
Contributor Author

Hotell commented Jun 8, 2018

Yo @johnnyreilly you're more than welcome man! sorry I didn't include this in former PR. thanks for merging ! cheers

@johnnyreilly
Copy link
Member

No worries - released with https://github.com/TypeStrong/ts-loader/releases/tag/v4.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants