New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix REPL bug with previous line carryover #1480
Merged
cspotcode
merged 8 commits into
TypeStrong:main
from
TheUnlocked:fix-previous-line-carryover
Oct 6, 2021
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
58136fc
Fix expressions carrying over from the previous line
TheUnlocked 336ea8f
Simplify semicolon insertion logic and avoid issues with line number
TheUnlocked 54be546
fix-previous-line-carryover: Add tests, simplify code, remove dead code
TheUnlocked d5eff7d
Minor refactor of ASI and and test tweak
TheUnlocked 8a5bec8
Fix linting issue
TheUnlocked 126b09f
Avoid adding a semicolon if one already exists, since TS emits double…
cspotcode 1c90eb9
lint-fix
cspotcode 63385d6
Add test case for avoiding double-semicolons; also fix tests to allow…
cspotcode File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A detailed explanation within the code! Love it; thanks for this.