Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fire dblclick on disabled form control elements #20723

Merged
merged 1 commit into from
Nov 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ PASS Testing click events when clicking child of disabled button.
PASS Testing click events when clicking child of disabled my-control.
PASS Testing click events when clicking disabled button.
PASS Testing click events when clicking disabled my-control.
FAIL Testing dblclick events when clicking child of disabled button. assert_equals: parent element received dblclick events expected false but got true
FAIL Testing dblclick events when clicking child of disabled my-control. assert_equals: parent element received dblclick events expected false but got true
FAIL Testing dblclick events when clicking disabled button. assert_equals: parent element received dblclick events expected false but got true
FAIL Testing dblclick events when clicking disabled my-control. assert_equals: parent element received dblclick events expected false but got true
PASS Testing dblclick events when clicking child of disabled button.
PASS Testing dblclick events when clicking child of disabled my-control.
PASS Testing dblclick events when clicking disabled button.
PASS Testing dblclick events when clicking disabled my-control.

Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ PASS Testing click events when clicking child of disabled button.
PASS Testing click events when clicking child of disabled my-control.
PASS Testing click events when clicking disabled button.
PASS Testing click events when clicking disabled my-control.
FAIL Testing dblclick events when clicking child of disabled button. assert_equals: child element received dblclick events expected true but got false
FAIL Testing dblclick events when clicking child of disabled my-control. assert_equals: child element received dblclick events expected true but got false
PASS Testing dblclick events when clicking child of disabled button.
PASS Testing dblclick events when clicking child of disabled my-control.
PASS Testing dblclick events when clicking disabled button.
PASS Testing dblclick events when clicking disabled my-control.

Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ PASS Testing click events when clicking child of disabled button.
PASS Testing click events when clicking child of disabled my-control.
PASS Testing click events when clicking disabled button.
PASS Testing click events when clicking disabled my-control.
FAIL Testing dblclick events when clicking child of disabled button. assert_equals: child element received dblclick events expected true but got false
FAIL Testing dblclick events when clicking child of disabled my-control. assert_equals: child element received dblclick events expected true but got false
PASS Testing dblclick events when clicking child of disabled button.
PASS Testing dblclick events when clicking child of disabled my-control.
PASS Testing dblclick events when clicking disabled button.
PASS Testing dblclick events when clicking disabled my-control.

2 changes: 1 addition & 1 deletion Source/WebCore/dom/EventDispatcher.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ void EventDispatcher::dispatchEvent(Node& node, Event& event)
EventPath eventPath { node, event };

if (node.document().settings().sendMouseEventsToDisabledFormControlsEnabled() && event.isTrusted() && event.isMouseEvent()
&& (event.type() == eventNames().mousedownEvent || event.type() == eventNames().mouseupEvent || event.type() == eventNames().clickEvent)) {
&& (event.type() == eventNames().mousedownEvent || event.type() == eventNames().mouseupEvent || event.type() == eventNames().clickEvent || event.type() == eventNames().dblclickEvent)) {
eventPath.adjustForDisabledFormControl();
}

Expand Down