[RNMobile] Invert the expect matcher values of the e2e tests #28770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
added
[Type] Task
6 tasks
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg mobile PRwordpress-mobile/gutenberg-mobile#3110Description
In the PR #27334 the code powering the e2e tests was refactored. During this refactoring the expect matcher was introduced to test results that were created in the respective tests for equality. There were a few tests that had expectation objects with values the other should have, so this PR seeks to do an inversion of these operations. So the order should be
expect(received).toBe(expected)so now the matches will resembleexpect( html... ).toBe(testData...)instead ofexpect( testData... ).toBe(html...)How has this been tested?
npm run native test:e2e:ios:localandnpm run native test:e2e:android:localshould work as before.Checklist: