Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert the expect matcher values of the e2e tests #3110

Merged
merged 8 commits into from Feb 7, 2021

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Feb 5, 2021

gutenberg PR WordPress/gutenberg#28770

To test:

  • CI: Full E2E Test suite should pass.
  • Locally: npm run test:e2e:ios:local and npm run test:e2e:android:local should work as before.

N.B I was having a local issue with Apium so I am using CI to verify the tests. If they fail I will resolve the issue.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 5, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-alexander jd-alexander merged commit f4b5931 into develop Feb 7, 2021
@jd-alexander jd-alexander deleted the fix/ui-tests-expect-fix branch February 7, 2021 00:17
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants