Site Editor: Use site title as a link #61258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
Size Change: +28 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
May 1, 2024
There was a problem hiding this comment.
I think this approach makes sense, but I would like to suggest three things.
- How about using the original icon instead? This matches the icon in the "View Site" menu:
- What do you think about adding transition effects?
1213c99ea616364a98a825545ae23084.mp4
- It seems to cause overflow when the site title is long.
| trunk | This PR |
|---|---|
 |
 |
Also, I think this change requires feedback on accessibility, so I'll ping @afercia.
|
I'd support this as a very simple plan forward.
One of the benefits of using the |
|
A part of me would also like to use the link.mov |
The same link within the WordPress admin bar does not use underline on hovers, I don't think we need to here.
I agree.
I'll check this out. I think it's because I'm using the component. |
richtabor
force-pushed
the
enhance/site-title-hover-link
branch
from
b3dff02
to
5940de0
Compare
|
I added this in eff5075.
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jarekmorawski. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
May 12, 2024
There was a problem hiding this comment.
Thanks for the update.
The overflow when the title is long has been resolved, but the glyph is pushed outside.
I would expect it to look like the following.
There may be a better way to write it, but I would like to suggest one approach to solving this problem.
diff --git a/packages/edit-site/src/components/site-hub/style.scss b/packages/edit-site/src/components/site-hub/style.scss
index 7b0c59d752..7d856e6f50 100644
--- a/packages/edit-site/src/components/site-hub/style.scss
+++ b/packages/edit-site/src/components/site-hub/style.scss
@@ -33,6 +33,8 @@
text-decoration: none;
white-space: nowrap;
text-overflow: ellipsis;
+ position: relative;
+ padding-right: $grid-unit-15;
&:hover,
&:focus,
@@ -44,8 +46,9 @@
&:focus::after,
&:active::after {
content: "↗";
+ position: absolute;
font-weight: 400;
- margin-left: $grid-unit-05;
+ right: 0;
}
}Another concern is that the clickable area is narrower because it is a text link. What do you think about removing variant="link" from this element and applying size="compact"?
Before:
After:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An alternative to #51852.
Testing Instructions
Screenshots or screencast
CleanShot.2024-04-30.at.13.28.27.mp4