Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using the wporg/query-filter block on the plugin directory #202

Draft
wants to merge 35 commits into
base: trunk
Choose a base branch
from
Draft

Try using the wporg/query-filter block on the plugin directory #202

wants to merge 35 commits into from

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Feb 14, 2024 •
edited

This is a work-in-progress draft attempt at seeing if it's possible to integrate the wporg/query-filter block into the plugin directory, and how that would look.

See https://meta.trac.wordpress.org/ticket/2753

  • This PR is not a guarantee of seeing it on w.org/plugins anytime soon.
  • The code is not intended to be production ready.
  • The filtering most likely doesn't work with search, due to no conversion to Jetpack ES args happening (Test with a /tag/.../ url, or possibly /author/)
  • It's likely that we wouldn't want this sorting/filtering hitting WP_Query => DB ever, as it uses meta_queries, which are most likely not performant for our scale. Thats to suggest, that we'd probably want to limit this to ES-backed views only.
Before After
Screenshot 2024-02-14 at 6 45 36 pm Screenshot 2024-02-14 at 6 40 18 pm
  • Yes, The count is wrong
  • Yes, The screenshots are of two different queries
  • Yes, The search is duplicated
  • Yes, The whitespace is off

@dd32
Store a num_ratings postmeta.
e0df0ac
@dd32
Add various orderby functions.
183703f
@dd32
Allow for querying for '?rating=3' for 3+stars.
20264b2
@dd32
Disable the no-results tag redirect, temporarily.
73a8254
@dd32
When ordering by last_updated, show the date on the cards.
d8bb2fb
@dd32
Initial hacky attempt at adding the wporg/query-filter bar.
46a41aa
@dd32
Slim down the global styles import to the minimal needed CSS.
78107c5
@dd32
Set more styles, remove the not-needed margins.
2ab01a2
@dd32
Rename Business model to Type.
ce21c28
@dd32
Register Tags before Categories.
f8ceddb
@dd32
Search: Add Taxonomy & Post Meta query and custom Sorting support.
fe8a779
@dd32
Search: Tighten.
9452eb3
@dd32
Don't order searches by active_installs.
42291bc
@dd32
Search: Better field mapping.
13be97a
@dd32
Simplify the front-end rules.
3c2a9bc
@dd32
Rename Categories, add counts.
38baae7 
Co-Authored-By: <dufresnesteven@git.wordpress.org>
@dd32
Remove the filter bar entirely.
af6889f
@dd32
Move to dedicated file.
98a635d
@dd32
Ditch Rating filters, as requested.
68364a9
@dd32
Merge branch 'trunk' into plugins/try-filter-bar
cd51113
@dd32
Remove unneeded sorts.
60bbdd5
@dd32
Remove filter-by-rating.
adeee01
@dd32
Cleanup ordering
29f2c09
@dd32
Allow the Sort by to override teh default orderings.
d8d6c19
@dd32
Search: Cleanup arrays.
062efa2
@dd32
Header: Make the filterbar more production ready.
52560e1
@dd32
Fix the sort-by most-used.
0a076de
@dd32
Remove the no-posts tax redirect.
b5373de
@dd32
Avoid a fatal when orderby is an array.
e7e317d
@dd32
Search: When sorting, take into account relevance.
a7145b0
bazza pushed a commit that referenced this pull request Mar 14, 2024
@dd32
wporg-plugins-2024: Initil conversion of the filter bar into a top-of…
2be6b42 
…-content query filter bar, with filters, search, & sort.

See #202


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13333 74240141-8908-4e6f-9713-ba540dce6ec7
@dd32 dd32 mentioned this pull request May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dd32