Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi platform docker build #201

Merged
merged 2 commits into from Jun 7, 2022
Merged

Multi platform docker build #201

merged 2 commits into from Jun 7, 2022

Conversation

zigarn
Copy link
Member

@zigarn zigarn commented May 15, 2022

Fixes #152
Supersedes #182

DockerHub autobuild doesn't support build for ARM (docker/roadmap#109), so switch to GitHub Actions for multi-platform (amd64 & arm64) docker build.

Build amd64 & test for every PR.
Build multi-platform & push only when push on master.

Adaptations:

  • sequential build of flavors: this way the with-xxx is built against the latest from same build instead of previous one
  • added tests for each flavor (requires absolute paths in Dockerfiles)

@jlandure: I did put my own DOCKERHUB_(USERNAME|TOKEN) as secret, should change it for the technical account dsizenika.

Result: https://github.com/zigarn/alpine-chrome/actions/runs/2327992742 & https://hub.docker.com/repository/docker/zigarn/alpine-chrome-multi-arch/tags

@zigarn zigarn requested review from jlandure and hgwood May 15, 2022 18:00
Copy link
Member

@hgwood hgwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

.github/workflows/build.yml Outdated Show resolved Hide resolved
@hgwood hgwood merged commit d802cbe into Zenika:master Jun 7, 2022
@zigarn zigarn deleted the multi-platform branch June 7, 2022 08:39
@zigarn
Copy link
Member Author

zigarn commented Jun 7, 2022

@hgwood: need to think to remove auto-build on DockerHub.

@willjosefi
Copy link

willjosefi commented Jun 10, 2022

hey guys!
seems like the PR is merged but I'm not seeing the images from arm64 inside docker hub
plus... seems like gh actions had a failure

@zigarn
Copy link
Member Author

zigarn commented Jun 10, 2022

Yes, there are some authentication issues blocking the push.
@jlandure or @hgwood: if you can give me back access to the Zenika's org on DockerHub, I can get the GCR credentials from there (if it's still there) and test what's wrong with it.

@hgwood
Copy link
Member

hgwood commented Jun 13, 2022

@zigarn Done :)

@zigarn
Copy link
Member Author

zigarn commented Jun 13, 2022

@zigarn
Copy link
Member Author

zigarn commented Jun 13, 2022

Improved by using a not base64 version of the GCR_JSON_KEY: login is OK: https://github.com/Zenika/alpine-chrome/runs/6858273478?check_suite_focus=true
But push is not...

@zigarn
Copy link
Member Author

zigarn commented Jun 13, 2022

@willjosefi: arm64 images are now available!
(https://github.com/zigarn/alpine-chrome/actions/runs/2327992742)

@zigarn zigarn mentioned this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes on Apple Silicon
3 participants