Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update http crate #3208

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: update http crate #3208

wants to merge 4 commits into from

Conversation

morenol
Copy link

@morenol morenol commented Dec 2, 2023

Depends on actix/actix-net#508

PR Type

Updates http crate

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

@robjtede
Copy link
Member

robjtede commented Dec 2, 2023

I'm curious if you have any particular motive to get this merged. From my PoV, the Actix Web project doesn't have any real need to do it.

@morenol
Copy link
Author

morenol commented Dec 2, 2023

Thanks for your feedback! I don't have any particular motive other than having that dependency up to date, so other crates that have actix-* as dependency can also update their http dependency to the latest one

@robjtede robjtede added B-semver-major breaking change requiring a major version bump A-http project: actix-http A-web project: actix-web labels Dec 6, 2023
@robjtede robjtede added this to the actix-web v5.0 milestone Dec 6, 2023
@therealprof
Copy link
Contributor

Not really sure how that happened but:

# cargo tree -i http@1.0.0
http v1.0.0
├── actix-tls v3.3.0
│   ├── actix-http v3.6.0
│   │   ├── actix-web v4.5.1
│   │   │   ├── actix-cors v0.7.0
...

whereas the rest of the actix universe is depending on 0.2. It is a bit unfortunate that one set of actix crates pulls in one dependency in two different versions.

@robjtede
Copy link
Member

robjtede commented Feb 7, 2024

Context for that particular change: actix/actix-net#508

@therealprof
Copy link
Contributor

I think switching to and using a 1.0 version is always a good venture due to the implied stability guarantees.

@juchiast
Copy link

Is there anything blocking this PR?

@juchiast
Copy link

I'm curious if you have any particular motive to get this merged. From my PoV, the Actix Web project doesn't have any real need to do it.

One use case is passing header values extracted from actix's request to other libraries, such as reqwest 0.12 .
Because of incompatible http version, we have to convert HeaderValue to bytes before passing.

@linuxtim
Copy link

linuxtim commented Apr 2, 2024

I'm curious if you have any particular motive to get this merged. From my PoV, the Actix Web project doesn't have any real need to do it.

Inevitably security support for http 0.2.x will cease long before security support for http 1.x does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http project: actix-http A-web project: actix-web B-semver-major breaking change requiring a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants