Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Extended argument types #48

Merged
merged 20 commits into from Dec 2, 2021

Conversation

adzialocha
Copy link
Owner

No description provided.

@adzialocha
Copy link
Owner Author

Thank you @davidgranstrom for this great feature! I've created the PR here now as you mentioned you are fine with merging it.

There has been some minor changes around npm dependencies and CI lately, also the lib folder is not checked-in anymore. I'm happy to review the PR if you could fix the conflicts whenever you find time.

@davidgranstrom
Copy link
Contributor

@adzialocha Thanks! I'll sort out the conflicts and get back to you soon.

@davidgranstrom
Copy link
Contributor

@adzialocha I've rebased the branch. All tests are passing locally but not the linter (unrelated to this PR though).

ESLint: 7.17.0

TypeError: Cannot read property 'value' of null
Occurred while linting /Users/dkg/code/javascript/osc-js/src/atomic/string.js:69

@adzialocha
Copy link
Owner Author

@adzialocha I've rebased the branch. All tests are passing locally but not the linter (unrelated to this PR though).

Oha! It looks like a bug in babel-eslint but even an upgrade didn't solve it. I could fix it by doing a fresh reinstall of all packages after deleting the package-lock.json (see related issue here: babel/babel#10904). The fix is pushed to master: d5693c6

@davidgranstrom
Copy link
Contributor

Okay! Lint is now passing after rebase and reinstall. I think this is ready for review!

@adzialocha adzialocha marked this pull request as ready for review March 13, 2021 13:28
@adzialocha
Copy link
Owner Author

10 million years later I could finally look at this, it looks super! Thank you so much @davidgranstrom!

@adzialocha adzialocha merged commit 091048d into adzialocha:master Dec 2, 2021
@davidgranstrom
Copy link
Contributor

@adzialocha Thanks, glad to hear! :)

@davidgranstrom davidgranstrom deleted the topic/message-types branch December 2, 2021 16:47
@adzialocha adzialocha mentioned this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants