Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

chore(deps): update dependency typescript to v4 #1917

Merged
merged 7 commits into from Aug 21, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 20, 2020

This PR contains the following updates:

Package Type Update Change
typescript (source) devDependencies major 3.9.7 -> 4.0.2

Release Notes

Microsoft/TypeScript

v4.0.2

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@machi1990
Copy link
Contributor

This is failing with

graphback/packages/graphback-runtime-knex/src/KnexDBDataProvider.ts
  0:0  error  Parsing error: Cannot read property 'map' of undefined

graphback/packages/graphback-runtime-mongodb/src/MongoDBDataProvider.ts
  0:0  error  Parsing error: Cannot read property 'map' of undefined

graphback/packages/graphback-runtime-mongodb/src/queryBuilder.ts
  0:0  error  Parsing error: Cannot read property 'map' of undefined

And this is because of this syntax which is not supported yet

import * as escapeRegex from "escape-string-regexp";

typescript-eslint/typescript-eslint#1436

/cc @craicoverflow @wtrocki

@machi1990
Copy link
Contributor

This is failing with

graphback/packages/graphback-runtime-knex/src/KnexDBDataProvider.ts
  0:0  error  Parsing error: Cannot read property 'map' of undefined

graphback/packages/graphback-runtime-mongodb/src/MongoDBDataProvider.ts
  0:0  error  Parsing error: Cannot read property 'map' of undefined

graphback/packages/graphback-runtime-mongodb/src/queryBuilder.ts
  0:0  error  Parsing error: Cannot read property 'map' of undefined

And this is because of this syntax which is not supported yet

import * as escapeRegex from "escape-string-regexp";

typescript-eslint/typescript-eslint#1436

/cc @craicoverflow @wtrocki

I guess it needed a combination of updates in #1895. I'll close that PR and push more fixes in this PR.

@machi1990
Copy link
Contributor

Ended up creating this b0016eb which disable some linting rules in graphql-serve package.

renovate-bot and others added 7 commits August 21, 2020 15:18
…e module

This was causing errors below that I failed to get rid off:

```
  error  Unsafe assignment of an any value    @typescript-eslint/no-unsafe-assignment
  error  Unsafe assignment of an any value    @typescript-eslint/no-unsafe-assignment
  error  Unsafe assignment of an any value    @typescript-eslint/no-unsafe-assignment
  error  Unsafe return of an any typed value  @typescript-eslint/no-unsafe-return
  error  Unsafe call of an any typed value    @typescript-eslint/no-unsafe-call
  error  Unsafe assignment of an any value    @typescript-eslint/no-unsafe-assignment
  error  Unsafe return of an any typed value  @typescript-eslint/no-unsafe-return
  error  Unsafe call of an any typed value    @typescript-eslint/no-unsafe-call
  error  Unsafe assignment of an any value    @typescript-eslint/no-unsafe-assignment
  error  Unsafe call of an any typed value    @typescript-eslint/no-unsafe-call
```

This only happens if `yarn build` is not run before `yarn lint` i.e if
the project is not built.

If the project is built, everything works fine without the need of this
patch.
@machi1990 machi1990 merged commit 97e774c into master Aug 21, 2020
@machi1990 machi1990 deleted the renovate/major-all branch August 21, 2020 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants