Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer const over let #79

Closed
wants to merge 1 commit into from
Closed

Conversation

LinusU
Copy link

@LinusU LinusU commented Oct 10, 2018

In order to comply with this new standard rule ☺️

standard/eslint-config-standard#133

Description

Changed from let to const where the binding never changed

Motivation and Context

It complies with the next version of Standard

How Has This Been Tested?

Ran a local version of standard

Screenshots (if appropriate):

Types of changes

  • Bugfix
  • Feature
  • Performance Improvement
  • Tests (fix, improvement, new tests)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • I have reviewed the guidelines for contributing to this repository.

@LinusU
Copy link
Author

LinusU commented Oct 11, 2018

@ahmadnassri would you mind restarting the build for Node.js 8, seems like a temporary error during the install phase (npm ci)

@ahmadnassri
Copy link
Owner

resolved in v3.0.1

@ahmadnassri ahmadnassri closed this Nov 6, 2018
@LinusU LinusU deleted the prefer-const branch November 6, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants