Add rule "prefer-const" #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2018
|
Just over an hour 😅 |
|
For new major release (13), right? |
|
Yes 👍 Rule addition is basically always a breaking change in the eyes of Standard 👌 |
|
I strongly dislike this rule, as it removes my ability to signal to future readers of code that, while a variable is not mutated currently, mutation is perfectly acceptable. |
|
For anyone new coming in, there was some discussion around that argument here: standard/standard#159 (comment) I personally think that in practice that almost never happens, and that you can always use an eslint-disable comment to allow it in those rare cases, which also makes the future intent even more clear since there will be a comment next to it |
DiegoRBaquero
approved these changes
Jan 21, 2019
feross
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ecosystem impact:
babel-tape-runner(Prefer const over let wavded/babel-tape-runner#27)merge2(Prefer const over let teambition/merge2#23)magic-virtual-element(Prefer const over let dekujs/magic-virtual-element#7)echint(Prefer const over let ahmadnassri/echint#106)jsreport-core(Prefer const over let jsreport/jsreport-core#38)jsreport-express(Prefer const over let jsreport/jsreport-express#11)mkdirp-promise(Prefer const over let ahmadnassri/mkdirp-promise#83)har-validator(Prefer const over let ahmadnassri/node-har-validator#111)multihashes(Prefer const over let multiformats/js-multihash#58)thunk-redis(Prefer const over let thunks/thunk-redis#24)ipld(Prefer const over let ipld/js-ipld-dag-cbor#82)fs-writefile-promise(Prefer const over let ahmadnassri/node-fs-writefile-promise#79)html-validator(Prefer const over let zrrrzzt/html-validator#92)libp2p-tcp(Prefer const over let libp2p/js-libp2p-tcp#99)route-trie(Prefer const over let zensh/route-trie#14)respjs(Prefer const over let zensh/resp.js#2)hapi-swaggered(Prefer const over let z0mt3c/hapi-swaggered#174)js-data-adapter-tests(Prefer const over let js-data/js-data-adapter-tests#3)stringify-clone(Prefer const over let ahmadnassri/node-stringify-clone#59)ipfs-repo(Prefer const over let ipfs/js-ipfs-repo#178)toa-token(Prefer const over let toajs/toa-token#1)make-concurrent(Prefer const over let fanatid/make-concurrent#2)studynotes(Prefer const over let feross/studynotes.org#387)webtorrent-desktop(Prefer const over let webtorrent/webtorrent-desktop#1497)