Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[propose] update protoc_version to latest one that supports arm64 architecture #1575

Merged
merged 1 commit into from Feb 15, 2022
Merged

[propose] update protoc_version to latest one that supports arm64 architecture #1575

merged 1 commit into from Feb 15, 2022

Conversation

andreezy777
Copy link
Contributor

Hi, here is my proposal to update protoc version which will allow to run the project without manually specifying the version of protoc for each project separately.

For example, there is the same "issue", (I've got a Could not find protoc-3.11.0-osx-aarch_64.exe).
Also locally tested with 3.19.4 version and all seems ok.

Thanks.

raboof
raboof approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raboof
Copy link
Member

raboof commented Feb 15, 2022

Ah, I see for some reason the CLA validator didn't run for this PR yet - could you complete https://www.lightbend.com/contribute/cla please?

@andreezy777
Copy link
Contributor Author

Ah, I see for some reason the CLA validator didn't run for this PR yet - could you complete https://www.lightbend.com/contribute/cla please?

Done
image

@raboof raboof merged commit 9bf2100 into akka:main Feb 15, 2022
@andreezy777
Copy link
Contributor Author

@raboof Thanks and have a nice day!

@raboof
Copy link
Member

raboof commented Feb 15, 2022

@raboof Thanks and have a nice day!

You too!

raboof added a commit to raboof/akka-grpc that referenced this pull request Feb 15, 2022
@raboof
Update protobuf-java to 3.19.4
54d5a9d 
And check the groovy plugin is consistent.

Replaces akka#1560
Groovy plugin was already updated in akka#1575
@raboof raboof mentioned this pull request Feb 15, 2022
Merged
raboof added a commit that referenced this pull request Feb 15, 2022
@raboof
Update protobuf-java to 3.19.4 (#1576)
3460c6a 
* Update protobuf-java to 3.19.4

And check the groovy plugin is consistent.

Replaces #1560
Groovy plugin was already updated in #1575

* scalafmtSbt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreezy777 @raboof