Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Performance #544

Merged
merged 10 commits into from Nov 6, 2018
Merged

UI Performance #544

merged 10 commits into from Nov 6, 2018

Conversation

dkhurshudian
Copy link
Contributor

@dkhurshudian dkhurshudian commented Oct 31, 2018 •
edited

@dkhurshudian dkhurshudian changed the title WIP: UI Performance UI Performance Nov 5, 2018
@dkhurshudian dkhurshudian mentioned this pull request Nov 5, 2018
Closed
pudo
pudo requested changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@pudo pudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error on the console:

screenshot 2018-11-06 11 12 14

@dkhurshudian
Copy link
Contributor Author

Thanks for feedback @pudo!
This is a result of using React.lazy feature with react-route1. See this remix-run/react-router#6420 issue for more details.
If app works as expected I would suggest to merge with this error for now.
I think library owners will fix this later.

@pudo
Copy link
Contributor

pudo commented Nov 6, 2018

Argh, gotta love upstream issues. Ok, I'll take it :)

@pudo pudo merged commit 1421c3c into develop Nov 6, 2018
@pudo pudo deleted the davit/performance-optimisation branch November 6, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pudo pudo pudo approved these changes

@emmina emmina Awaiting requested review from emmina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkhurshudian @pudo