chore: unify and enforce import style to no extensions #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for algolia-instantsearch ready! Built with commit 20ad063 https://deploy-preview-3022--algolia-instantsearch.netlify.com |
| @@ -3,6 +3,7 @@ module.exports = { | |||
| rules: { | |||
| "no-param-reassign": 0, | |||
| "import/no-extraneous-dependencies": 0, | |||
| "react/no-string-refs": 1 | |||
| "react/no-string-refs": 1, | |||
| "import/extensions": [2, "always", {js: "never"}] | |||
There was a problem hiding this comment.
What about having this rule part of eslint-config-algolia?
There was a problem hiding this comment.
It's a first step :) But sure it's gonna end up there if we're happy about it.
There was a problem hiding this comment.
algolia/eslint-config-algolia#92 we'll remove the rule when it's merged and the config updated.
…clearRefinements-import-no-extension
samouss
approved these changes
Jul 3, 2018
bobylito
added a commit
that referenced
this pull request
Jul 4, 2018
* refactor(clearAll): rename clear all to clear refinements * feat(clear-refinements): update markup * feat(panel): upate dev-novel and misc. fixes * chore(clear-refinements): remove panel * chore: peer review * chore: unify and enforce import style to no extensions (#3022)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on @samouss comment, this PR activates import/extensions and configures to not accepts extensions for JS files.