Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unify and enforce import style to no extensions #3022

Merged
merged 2 commits into from
Jul 4, 2018
Merged

chore: unify and enforce import style to no extensions #3022

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b17319c
chore: unify and enforce import style to no extensions
Jul 2, 2018
20ad063
Merge branch 'feat/3.0-is.css-clearRefinements' into feat/3.0-is.css-…
bobylito Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@ module.exports = {
rules: {
"no-param-reassign": 0,
"import/no-extraneous-dependencies": 0,
"react/no-string-refs": 1
"react/no-string-refs": 1,
"import/extensions": [2, "always", {js: "never"}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about having this rule part of eslint-config-algolia?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a first step :) But sure it's gonna end up there if we're happy about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

algolia/eslint-config-algolia#92 we'll remove the rule when it's merged and the config updated.

}
}
6 changes: 3 additions & 3 deletions dev/app/builtin/init-stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import initAnalyticsStories from './stories/analytics.stories';
import initBreadcrumbStories from './stories/breadcrumb.stories.js';
import initClearRefinementsStories from './stories/clear-refinements.stories.js';
import initBreadcrumbStories from './stories/breadcrumb.stories';
import initClearRefinementsStories from './stories/clear-refinements.stories';
import initCurrentRefinedValuesStories from './stories/current-refined-values.stories';
import initGeoSearch from './stories/geo-search.stories';
import initHierarchicalMenu from './stories/hierarchical-menu.stories';
Expand All @@ -13,7 +13,7 @@ import initNumericRefinementListStories from './stories/numeric-refinement-list.
import initNumericSelectorStories from './stories/numeric-selector.stories';
import initPaginationStories from './stories/pagination.stories';
import initPriceRangesStories from './stories/price-ranges.stories';
import initRangeInputStories from './stories/range-input.stories.js';
import initRangeInputStories from './stories/range-input.stories';
import initRangeSliderStories from './stories/range-slider.stories';
import initRefinementListStories from './stories/refinement-list.stories';
import initReloadStories from './stories/reload.stories';
Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/analytics.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { action, storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Analytics');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/breadcrumb.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Breadcrumb');
export default () => {
Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/clear-refinements.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('ClearRefinements');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/configure.stories.js
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
import { storiesOf } from 'dev-novel';

import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Configure');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/current-refined-values.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('CurrentRefinedValues');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/hierarchical-menu.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('HierarchicalMenu');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/hits-per-page-selector.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('HitsPerPageSelector');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/hits.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Hits');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/infinite-hits.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('InfiniteHits');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/instantsearch.stories.js
View file
Open in desktop
@@ -1,7 +1,7 @@
/* eslint-disable import/default */

import { storiesOf } from 'dev-novel';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Instantsearch');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/menu.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Menu');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/numeric-refinement-list.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('NumericRefinementList');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/numeric-selector.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('NumericSelector');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/pagination.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Pagination');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/price-ranges.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('PriceRanges');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/range-input.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('RangeInput');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/range-slider.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('RangeSlider');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/refinement-list.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('RefinementList');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/reload.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Refresh');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/search-box.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('SearchBox');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/sort-by-selector.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('SortBySelector');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/star-rating.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('StarRating');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/stats.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Stats');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/builtin/stories/toggle.stories.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

import { storiesOf } from 'dev-novel';
import instantsearch from '../../../../index';
import { wrapWithHits } from '../../utils/wrap-with-hits.js';
import { wrapWithHits } from '../../utils/wrap-with-hits';

const stories = storiesOf('Toggle');

Expand Down
2 changes: 1 addition & 1 deletion dev/app/index.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@ import { registerDisposer, start } from 'dev-novel';
import initBuiltInWidgets from './builtin/init-stories';
import initJqueryWidgets from './jquery/init-stories';
import initVanillaWidgets from './vanilla/init-stories';
import initUnmountWidgets from './init-unmount-widgets.js';
import initUnmountWidgets from './init-unmount-widgets';

import '../style.css';

Expand Down
4 changes: 2 additions & 2 deletions dev/app/init-unmount-widgets.js
View file
Open in desktop
@@ -1,8 +1,8 @@
/* eslint-disable import/default */
import { storiesOf } from 'dev-novel';
import instantsearch from '../../index.js';
import instantsearch from '../../index';

import { wrapWithHits } from './utils/wrap-with-hits.js';
import { wrapWithHits } from './utils/wrap-with-hits';

function wrapWithUnmount(getWidget, params) {
return wrapWithHits(container => {
Expand Down
2 changes: 1 addition & 1 deletion dev/app/jquery/init-stories.js
View file
Open in desktop
@@ -1,4 +1,4 @@
import initClearRefinementsStories from './stories/clear-refinements.stories.js';
import initClearRefinementsStories from './stories/clear-refinements.stories';
import initCurrentRefinedValuesStories from './stories/current-refined-values.stories';
import initHierarchicalMenuStories from './stories/hierarchical-menu.stories';
import initHitsStories from './stories/hits.stories';
Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/autocomplete.stories.js
View file
Open in desktop
Expand Up @@ -2,8 +2,8 @@

import { action, storiesOf } from 'dev-novel';

import instantsearch from '../../../../index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import instantsearch from '../../../../index';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';

const stories = storiesOf('Autocomplete');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/clear-refinements.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('ClearAll');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/current-refined-values.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('CurrentRefinedValues');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/hierarchical-menu.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('HierarchicalMenu');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/hits-per-page-selector.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('HitsPerPageSelector');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/hits.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('Hits');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/infinite-hits.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('InfiniteHits');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/menu.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('Menu');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/numeric-refinement-list.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('NumericRefinementList');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/numeric-selector.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('NumericSelector');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/pagination.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('Pagination');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/price-ranges.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('PriceRanges');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/refinement-list.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('RefinementList');

Expand Down
4 changes: 2 additions & 2 deletions dev/app/jquery/stories/search-box.stories.js
View file
Open in desktop
@@ -1,6 +1,6 @@
import { storiesOf } from 'dev-novel';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits.js';
import * as widgets from '../widgets/index.js';
import { wrapWithHitsAndJquery } from '../../utils/wrap-with-hits';
import * as widgets from '../widgets/index';

const stories = storiesOf('SearchBox');

Expand Down