Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipboard: fix the lint crash by eslint-plugin-react #375

Merged
merged 1 commit into from Jul 27, 2020

Conversation

yorkie
Copy link
Member

@yorkie yorkie commented Jul 27, 2020

The eslint-plugin-react@7.20.4 introduced a crash bug when linting a source with an anonymous function with the ES modules. This PR removes all related anonymous functions to hotfix the problem.

See jsx-eslint/eslint-plugin-react#2728 for more information.

The eslint-plugin-react@7.20.4 introduced a crash bug when linting a source with anonymous function
with es module.

This PR removes all related anonymous functions to hotfix the problem.

See jsx-eslint/eslint-plugin-react#2728
@yorkie yorkie added the build CI/CD, and build stuffs label Jul 27, 2020
@yorkie yorkie requested a review from FeelyChau July 27, 2020 09:10
@rickycao-qy
Copy link
Collaborator

LGTM

Copy link
Collaborator

@FeelyChau FeelyChau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yorkie yorkie merged commit 3ced0bb into master Jul 27, 2020
@yorkie yorkie deleted the fix/eslint-react-error branch July 27, 2020 09:54
gindis pushed a commit to gindis/pipcook that referenced this pull request Sep 11, 2020
The eslint-plugin-react@7.20.4 introduced a crash bug when linting a source with anonymous function
with es module.

This PR removes all related anonymous functions to hotfix the problem.

See jsx-eslint/eslint-plugin-react#2728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI/CD, and build stuffs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants