Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, remove non-working CJS artifact #10

Merged
merged 6 commits into from Apr 29, 2023

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented Apr 27, 2023

See discussion in #8.

  • switch away from lodash-es to better maintained dependencies
  • update all dependencies including yarn to the latest with ncu
  • add devDependencies so that linter doesn't complain (not sure why transitive plugin deps worked before)
  • fix typescript 5 deprecation
  • remove non-working cjs package (see cjs workaround here Error [ERR_REQUIRE_ESM]: lodash-es #8 (comment))
📦 Published PR as canary version: 2.0.3--canary.10.59a9ede.0

✨ Test out this PR locally via:

npm install vite-plugin-i18next-loader@2.0.3--canary.10.59a9ede.0
# or 
yarn add vite-plugin-i18next-loader@2.0.3--canary.10.59a9ede.0

@rosskevin

This comment was marked as outdated.

@rosskevin

This comment was marked as outdated.

@rosskevin

This comment was marked as outdated.

@rosskevin
Copy link
Member Author

While this PR is good to go for ESM, we confirmed the use of runtime dependency dot-prop is a non-starter as it is ESM-only. We need alternatives that ship both cjs and esm distributables in a package of the same name with proper exports specified in the package.json.

@rosskevin rosskevin changed the title Cjs compatibility Update dependencies, remove non-working CJS artifact Apr 29, 2023
@rosskevin
Copy link
Member Author

We are removing the CJS artifact - this is discussed in #8 and a workaround for CJS users is here #8 (comment)

@rosskevin rosskevin merged commit a533e0e into main Apr 29, 2023
1 check passed
@rosskevin
Copy link
Member Author

🚀 PR was released in v2.0.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant