New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESM bug, remove private dep #9
Conversation
Please approve and release this. |
@rosskevin good for you to merge ? |
@gamegee @jamespearson until it gets merged feel free to use this one https://www.npmjs.com/package/vite-plugin-i18next-loader-cjs |
I'm sorry, I didn't get a notification on this! Only the comment. Reviewing now... |
"name": "vite-plugin-i18next-loader-cjs", | ||
"version": "2.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't bump the version, auto
will do that instead. Also change back the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey sure that makes sense!
I'm surprised that |
I didn't knew about auto when I opened the PR, I was mainly trying to fix it to use myself. You suggested to change back from lodash-es to lodash. That's what was fixing the issue! Any ideas how to solve properly? |
"marked": "^4.1.1", | ||
"marked-terminal": "^5.1.1" | ||
}, | ||
"devDependencies": { | ||
"@alienfast/eslint-config": "^4.0.5", | ||
"@types/js-yaml": "^4.0.5", | ||
"@types/lodash-es": "^4.17.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also don't forget to replace by @types/lodash
@agustif I looked into why a canary release wasn't added to this PR by I'm going to take a look at opening our eslint config so we can keep it. I'd prefer it. Give me a couple of hours to take a look at that - I should get this resolved today. |
Github package is public now for |
Closing in favor of my PR to solve this #10. I need the canary to be tested before I'll release it. Please take a look and test it out and comment there. |
Fixes #8