Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESM bug, remove private dep #9

Closed
wants to merge 11 commits into from
Closed

Fix ESM bug, remove private dep #9

wants to merge 11 commits into from

Conversation

agustif
Copy link

@agustif agustif commented Feb 20, 2023

Fixes #8

@jamespearson
Copy link

Please approve and release this.

@gamegee
Copy link

gamegee commented Apr 25, 2023

@rosskevin good for you to merge ?

@agustif
Copy link
Author

agustif commented Apr 25, 2023

@gamegee @jamespearson until it gets merged feel free to use this one https://www.npmjs.com/package/vite-plugin-i18next-loader-cjs

@rosskevin
Copy link
Member

I'm sorry, I didn't get a notification on this! Only the comment. Reviewing now...

Comment on lines +2 to +3
"name": "vite-plugin-i18next-loader-cjs",
"version": "2.0.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't bump the version, auto will do that instead. Also change back the name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey sure that makes sense!

@rosskevin
Copy link
Member

I'm surprised that auto didn't provide a usable release from this PR...I'll have to look at the settings.

@agustif
Copy link
Author

agustif commented Apr 26, 2023

I'm surprised that auto didn't provide a usable release from this PR...I'll have to look at the settings.

I didn't knew about auto when I opened the PR, I was mainly trying to fix it to use myself. You suggested to change back from lodash-es to lodash. That's what was fixing the issue! Any ideas how to solve properly?

"marked": "^4.1.1",
"marked-terminal": "^5.1.1"
},
"devDependencies": {
"@alienfast/eslint-config": "^4.0.5",
"@types/js-yaml": "^4.0.5",
"@types/lodash-es": "^4.17.6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't forget to replace by @types/lodash

@rosskevin
Copy link
Member

@agustif I looked into why a canary release wasn't added to this PR by auto, and it's because you included skip ci in your last message (HEAD) before you PR'd. If your latest commit was pushed - then you would have a canary to try.

I'm going to take a look at opening our eslint config so we can keep it. I'd prefer it. Give me a couple of hours to take a look at that - I should get this resolved today.

@rosskevin
Copy link
Member

Github package is public now for @alienfast/eslint-config, I'll take a shot at this myself in another PR and we can try it out.

@rosskevin
Copy link
Member

Closing in favor of my PR to solve this #10. I need the canary to be tested before I'll release it. Please take a look and test it out and comment there.

@rosskevin rosskevin closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error [ERR_REQUIRE_ESM]: lodash-es
4 participants