Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: commit conventions #200

Closed
wants to merge 3 commits into from

Conversation

Berkmann18
Copy link
Member

@Berkmann18 Berkmann18 commented Apr 29, 2019

Follow up of all-contributors/cli#159 but for the bot.

Instead of a "bespoke" duplicate solution, use a package for commit convertion.

re all-contributors#132
@jakebolam
Copy link
Contributor

This looks great. Almost there @Berkmann18 !

@jakebolam jakebolam changed the title Commit conventions feat: commit conventions May 4, 2019
@jsoref
Copy link
Contributor

jsoref commented Jan 18, 2021

@jakebolam do you happen to remember what the difference between almost there and ready was?

I understand this PR is stale (conflicts)... But without a hint about what's missing, it seems hard for anyone to pick up.

@gr2m
Copy link
Contributor

gr2m commented Jan 18, 2021

I think this PR can be closed. I would not enforce commit conventions on contributors, we can fix the commit messages using squash & merge when merging PRs. I'd suggest we close the PR @Berkmann18

@Berkmann18
Copy link
Member Author

Berkmann18 commented Jan 18, 2021

I think this PR can be closed. I would not enforce commit conventions on contributors, we can fix the commit messages using squash & merge when merging PRs. I'd suggest we close the PR @Berkmann18

For this org sure, but for others where the commit convention isn't the same, it makes it an unnecessary annoyance.
And since this PR was done from my fork, I'll close it and open a new one.

@gr2m
Copy link
Contributor

gr2m commented Jan 18, 2021

sorry, nevermind my comment, I misunderstood the PR. I thought it was about enforcing commit messages in this repository, not supporting multiple commit conventions by the app.

@Berkmann18
Copy link
Member Author

Ah ok, no worries, it was indeed aimed at other repos where the app is used.

@Berkmann18 Berkmann18 closed this Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants