Fix domain deleting when fail on not exist stack #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stack not exists `findApiId()` fails on `getStack()` and then on `getNestedStack()`. Try block in `removeBasePathMappings()` do not set `externalBasePathExists` flag. As result domain that has other mappings are removed. This fix adds extra check to catch block of `removeBasePathMappings()` if option `preserveExternalPathMappings` is set in stack config (by setting this option user identify that domain should have another mappings) and set the flag `externalBasePathExists` that prevent removing domain.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Description of Issue Fixed
When stack not exists
findApiId()fails ongetStack()and then ongetNestedStack(). Try block inremoveBasePathMappings()do not setexternalBasePathExistsflag. As result domain that has other mappings are removed.Changes proposed in this pull request:
This fix adds extra check to catch block of
removeBasePathMappings()if optionpreserveExternalPathMappingsis set in stack config (by setting this option user identify that domain should have another mappings) and set the flagexternalBasePathExiststhat prevent removing domain.