Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix domain deleting when fail on not exist stack #627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix domain deleting when fail on not exist stack #627

wants to merge 1 commit into from

Commits on Apr 7, 2024

  1. Fix domain deleting when fail on not exist stack 

    When stack not exists `findApiId()` fails on `getStack()` and then on `getNestedStack()`. Try block in `removeBasePathMappings()` do not set `externalBasePathExists` flag. As result domain that has other mappings are removed. This fix adds extra check to catch block of `removeBasePathMappings()` if option `preserveExternalPathMappings` is set in stack config (by setting this option user identify that domain should have another mappings) and set the flag `externalBasePathExists` that prevent removing domain.
    @0vvland
    0vvland committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    6f72d9d View commit details
    Browse the repository at this point in the history