stop dispatching events after eventsource is closed #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to the spec eventsource should only dispatch events if it is not in the `CLOSED` state see point 8 in this portion of the spec: https://html.spec.whatwg.org/multipage/server-sent-events.html#event-stream-interpretation Before this fix the implementation was dispatching all events received in a single chunk, even if the EventStream was closed while processing one of those events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the spec eventsource should only dispatch events if it is
not in the
CLOSEDstatesee point 8 in this portion of the spec:
https://html.spec.whatwg.org/multipage/server-sent-events.html#event-stream-interpretation
Before this fix the implementation was dispatching all events received
in a single chunk, even if the EventStream was closed while processing
one of those events.