Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop dispatching events after eventsource is closed #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

stop dispatching events after eventsource is closed #19

wants to merge 1 commit into from

Commits on Jan 9, 2018

  1. stop dispatching events after eventsource is closed 

    according to the spec eventsource should only dispatch events if it is
not in the `CLOSED` state

see point 8 in this portion of the spec:
https://html.spec.whatwg.org/multipage/server-sent-events.html#event-stream-interpretation

Before this fix the implementation was dispatching all events received
in a single chunk, even if the EventStream was closed while processing
one of those events.
    @pirxpilot
    pirxpilot committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    791d2cc View commit details
    Browse the repository at this point in the history