fix(eslint-plugin-template): no-call-expression not reporting failures for safe method c… #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
commented
Dec 25, 2020
Comment on lines
-41
to
-48
| convertAnnotatedSourceToFailureCase({ | ||
| description: 'it should fail with call expression in expression binding', | ||
| annotatedSource: ` | ||
| <a href="http://example.com">{{ getInfo() }}</a> | ||
| ~~~~~~~~~ | ||
| `, | ||
| messageId, | ||
| }), |
There was a problem hiding this comment.
Removed as duplicated test.
rafaelss95
commented
Dec 25, 2020
Comment on lines
+61
to
+60
| {{ obj?.nested1() }} {{ obj!.nested1() }} | ||
| ~~~~~~~~~~~~~~ ^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
@JamesHenry, 2 points to notice here:
- While I was doing this, I remembered that we discussed this at feat(eslint-plugin-template): no-any #205 (comment), so I decided to debug deeper this time and finally figured out why it happens. The "problem" is that Angular condenses consequent interpolations in a single
BoundText, and so in order to check the error by passing achar, we should inline all the interpolations in a single line.
- Despite having solved this one, I wasn't able to solve the one where the error column is off by one (the same we discussed in the
template-no-anyin the link above)... maybe is it an bug withgetLocFromIndex? I also noticed that it was reported in Column numbers are off by one when codelyzer reports errors in template files mgechev/codelyzer#859.
rafaelss95
force-pushed
the
fix/no-call-expression
branch
from
a6492a5
to
97e81d4
Compare
rafaelss95
force-pushed
the
fix/no-call-expression
branch
from
97e81d4
to
d6ec28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alls
As reported in mgechev/codelyzer#757,
no-call-expressiondoesn't report failures for safe method calls, e.g.:{{ a?.b() }}About mgechev/codelyzer#757 (comment), I don't know if we would be able to perform this check without turn the
requiresTypeCheckingon...