New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(service-worker): ensure initialization before handling messages #32525
fix(service-worker): ensure initialization before handling messages #32525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for taking this on, @Splaktar ❤️
I have left a couple of suggestions. We should also have some tests for this new behavior.
@Splaktar #nudge :) |
Will this be available in next release |
@rebendajirijr: Only if the PR is merged in time for the release 😉 |
@gkalpak yeah, I've just been busy with Ivy-related testing/fixes. I will try to get back to this soon. Feel free to take over if you have time to address it now. |
5c3a405
to
0132797
Compare
I've added a test for I haven't been able to reproduce the |
I have made some changes (including a test for Could you port the changes over to your branch to update the PR, @Splaktar? 🙏 |
@gkalpak will do! I do have it set to allow edits from maintainers. So I'm not sure what the issue is, but I'll update ASAP, many thanks! |
0132797
to
e653231
Compare
@gkalpak OK, changes applied. Fixed a typo or two. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Can you please update the commit message to not mention fetch (because this commit does not really affect how fetch
is handled - initialization did already happen before fetch
).
- resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes angular#25611
e653231
to
afba739
Compare
@gkalpak done. |
…ngular#32525) - resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes angular#25611 PR Close angular#32525
…ngular#32525) - resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes angular#25611 PR Close angular#32525
…ngular#32525) - resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes angular#25611 PR Close angular#32525
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Service workers can fail after updates with the exception:
Invariant violated (initialize): latest hash null has no known manifest
.Issue Number:
Fixes #25611
What is the new behavior?
through all of August
Does this PR introduce a breaking change?
Other information
Fix suggested by @gkalpak. Similar code can be found in
Driver.handleFetch()
.