fix(language-service): Should not crash if expr ends unexpectedly #33524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is any parser errors when parsing template, we should stop immediately and not proceed with template expression diagnostics. This regression is caused by angular@6d11154 and affected v9.0.0-next.4 onwards. PR closes angular/vscode-ng-language-service#436
kyliau
added
area: language-service
ayazhafiz
approved these changes
Oct 31, 2019
atscott
pushed a commit
that referenced
this pull request
Nov 1, 2019
…3524) If there is any parser errors when parsing template, we should stop immediately and not proceed with template expression diagnostics. This regression is caused by 6d11154 and affected v9.0.0-next.4 onwards. PR closes angular/vscode-ng-language-service#436 PR Close #33524
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…gular#33524) If there is any parser errors when parsing template, we should stop immediately and not proceed with template expression diagnostics. This regression is caused by angular@6d11154 and affected v9.0.0-next.4 onwards. PR closes angular/vscode-ng-language-service#436 PR Close angular#33524
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…gular#33524) If there is any parser errors when parsing template, we should stop immediately and not proceed with template expression diagnostics. This regression is caused by angular@6d11154 and affected v9.0.0-next.4 onwards. PR closes angular/vscode-ng-language-service#436 PR Close angular#33524
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is any parser errors when parsing template, we should stop
immediately and not proceed with template expression diagnostics.
This regression is caused by 6d11154
and affected v9.0.0-next.4 onwards.
PR closes angular/vscode-ng-language-service#436
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information