Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-service): Should not crash if expr ends unexpectedly #33524

Closed
wants to merge 1 commit into from
Closed

fix(language-service): Should not crash if expr ends unexpectedly #33524

wants to merge 1 commit into from

Commits on Oct 31, 2019

  1. fix(language-service): Should not crash if expr ends unexpectedly 

    If there is any parser errors when parsing template, we should stop
immediately and not proceed with template expression diagnostics.

This regression is caused by angular@6d11154
and affected v9.0.0-next.4 onwards.

PR closes angular/vscode-ng-language-service#436
    @kyliau
    kyliau committed Oct 31, 2019
    Copy the full SHA
    64cf510 View commit details
    Browse the repository at this point in the history