Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to Angular CLI 9.0.0-rc.3 #33955

Closed
wants to merge 2 commits into from
Closed

build: update to Angular CLI 9.0.0-rc.3 #33955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b052906
build: update to Angular CLI 9.0.0-rc.3
filipesilva Nov 21, 2019
3bfeee4
build: update @schematics/angular to 9.0.0-rc.3
filipesilva Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 15 additions & 15 deletions aio/package.json
View file
Open in desktop
Expand Up @@ -87,28 +87,28 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^9.0.0-rc.1",
"@angular/animations": "^9.0.0-rc.3",
"@angular/cdk": "9.0.0-next.0",
"@angular/common": "^9.0.0-rc.1",
"@angular/compiler": "^9.0.0-rc.1",
"@angular/core": "^9.0.0-rc.1",
"@angular/elements": "^9.0.0-rc.1",
"@angular/forms": "^9.0.0-rc.1",
"@angular/common": "^9.0.0-rc.3",
"@angular/compiler": "^9.0.0-rc.3",
"@angular/core": "^9.0.0-rc.3",
"@angular/elements": "^9.0.0-rc.3",
"@angular/forms": "^9.0.0-rc.3",
"@angular/material": "9.0.0-next.0",
"@angular/platform-browser": "^9.0.0-rc.1",
"@angular/platform-browser-dynamic": "^9.0.0-rc.1",
"@angular/router": "^9.0.0-rc.1",
"@angular/service-worker": "^9.0.0-rc.1",
"@angular/platform-browser": "^9.0.0-rc.3",
"@angular/platform-browser-dynamic": "^9.0.0-rc.3",
"@angular/router": "^9.0.0-rc.3",
"@angular/service-worker": "^9.0.0-rc.3",
"@webcomponents/custom-elements": "^1.2.0",
"rxjs": "^6.5.3",
"tslib": "^1.10.0",
"zone.js": "~0.10.2"
},
"devDependencies": {
"@angular-devkit/build-angular": "0.900.0-rc.0",
"@angular/cli": "9.0.0-rc.0",
"@angular/compiler-cli": "^9.0.0-rc.1",
"@angular/language-service": "^9.0.0-rc.1",
"@angular-devkit/build-angular": "0.900.0-rc.3",
"@angular/cli": "9.0.0-rc.3",
"@angular/compiler-cli": "^9.0.0-rc.3",
"@angular/language-service": "^9.0.0-rc.3",
"@types/jasmine": "^3.4.2",
"@types/jasminewd2": "^2.0.8",
"@types/lunr": "^2.3.2",
Expand Down Expand Up @@ -175,4 +175,4 @@
"xregexp": "^4.0.0",
"yargs": "^7.0.2"
}
}
}
2 changes: 1 addition & 1 deletion aio/scripts/_payload-limits.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"master": {
"uncompressed": {
"runtime-es2015": 2987,
"main-es2015": 506857,
"main-es2015": 464734,
Copy link
Member

@gkalpak gkalpak Nov 21, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context:
This was temporarily changed from 461159 to 506857 (pending a cli release) in 08a4f10.
So, there seems to be 3.5KB regression (461159 --> 464734) from rc.1 to rc.3. EDIT: Not true. 👇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to say actually. It's true that the commit you linked changed the value. But that wasn't the absolute value, it was a value within +-1% of the real value.

Which is to say, I could have put that value and it would have still passed the CI. To know if there's a regression or not we'd need to check the sizes of FW+CLI rc.2 and FW+CLI rc.3 for AIO.

It's unfortunate that we can't vary just one. Next time we do this sort of coordinated change we should instead leave one of the packages (either FW or CLI) in a intermediate compat mode (@clydin suggested this approach for the change in question, but we ended up not going with it).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Moreover, this size is for building with the local packages (so neither rc.1 nor rc.3) 😁
So, my comment was invalid 😇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did both builds:

  • FW+CLI rc.2: 464103
  • FW+CLI rc.3: 464814

So yes, there was a change of 701 bytes. I don't know if it was CLI or the FW though.

"polyfills-es2015": 52503
}
}
Expand Down
787 changes: 463 additions & 324 deletions aio/yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration/_payload-limits.json
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@
"master": {
"uncompressed": {
"runtime-es2015": 2289,
"main-es2015": 312772,
"main-es2015": 267979,
"polyfills-es2015": 36808,
"5-es2015": 751
}
Expand Down
2 changes: 1 addition & 1 deletion integration/bazel-schematics/test.sh
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@ function testNonBazel() {
# disable CLI's version check (if version is 0.0.0, then no version check happens)
yarn --cwd node_modules/@angular/cli version --new-version 0.0.0 --no-git-tag-version
# re-add build-angular
yarn add --dev @angular-devkit/build-angular@0.900.0-rc.0
yarn add --dev @angular-devkit/build-angular@0.900.0-rc.3
yarn webdriver-manager update --gecko=false --standalone=false ${CI_CHROMEDRIVER_VERSION_ARG:---versions.chrome 2.45}
ng build --progress=false
ng test --progress=false --watch=false
Expand Down
2 changes: 1 addition & 1 deletion integration/cli-hello-world-ivy-compat/package.json
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@
"zone.js": "file:../../dist/zone.js-dist/zone.js"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.900.0-rc.0",
"@angular-devkit/build-angular": "^0.900.0-rc.3",
"@angular/cli": "file:../../node_modules/@angular/cli",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/language-service": "file:../../dist/packages-dist/language-service",
Expand Down
2 changes: 1 addition & 1 deletion integration/cli-hello-world-ivy-i18n/package.json
View file
Open in desktop
Expand Up @@ -34,7 +34,7 @@
"zone.js": "file:../../dist/zone.js-dist/zone.js"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.900.0-rc.0",
"@angular-devkit/build-angular": "^0.900.0-rc.3",
"@angular/cli": "file:../../node_modules/@angular/cli",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/language-service": "file:../../dist/packages-dist/language-service",
Expand Down
2 changes: 1 addition & 1 deletion integration/cli-hello-world-ivy-minimal/package.json
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@
"zone.js": "file:../../dist/zone.js-dist/zone.js"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.900.0-rc.0",
"@angular-devkit/build-angular": "^0.900.0-rc.3",
"@angular/cli": "file:../../node_modules/@angular/cli",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/language-service": "file:../../dist/packages-dist/language-service",
Expand Down
2 changes: 1 addition & 1 deletion integration/cli-hello-world-lazy-rollup/package.json
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@
"zone.js": "file:../../dist/zone.js-dist/zone.js"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.900.0-rc.0",
"@angular-devkit/build-angular": "^0.900.0-rc.3",
"@angular/cli": "file:../../node_modules/@angular/cli",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/language-service": "file:../../dist/packages-dist/language-service",
Expand Down
2 changes: 1 addition & 1 deletion integration/cli-hello-world-lazy/package.json
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@
"zone.js": "file:../../dist/zone.js-dist/zone.js"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.900.0-rc.0",
"@angular-devkit/build-angular": "^0.900.0-rc.3",
"@angular/cli": "file:../../node_modules/@angular/cli",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/language-service": "file:../../dist/packages-dist/language-service",
Expand Down
2 changes: 1 addition & 1 deletion integration/cli-hello-world/package.json
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@
"zone.js": "file:../../dist/zone.js-dist/zone.js"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.900.0-rc.0",
"@angular-devkit/build-angular": "^0.900.0-rc.3",
"@angular/cli": "file:../../node_modules/@angular/cli",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/language-service": "file:../../dist/packages-dist/language-service",
Expand Down
2 changes: 1 addition & 1 deletion integration/ivy-i18n/package.json
View file
Open in desktop
Expand Up @@ -48,7 +48,7 @@
"zone.js": "file:../../dist/zone.js-dist/zone.js"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.900.0-rc.0",
"@angular-devkit/build-angular": "^0.900.0-rc.3",
"@angular/cli": "file:../../node_modules/@angular/cli",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/language-service": "file:../../dist/packages-dist/language-service",
Expand Down
2 changes: 1 addition & 1 deletion integration/ng_update_migrations/package.json
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@
"zone.js": "file:../../dist/zone.js-dist/zone.js"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.900.0-rc.0",
"@angular-devkit/build-angular": "^0.900.0-rc.3",
"@angular/cli": "file:../../node_modules/@angular/cli",
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
"@angular/language-service": "file:../../dist/packages-dist/language-service",
Expand Down
2 changes: 1 addition & 1 deletion integration/ng_update_migrations/test.js
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@ const toVersion = '9.0.0';
// Note that we need to specify "--allow-dirty" as the repository will become dirty
// if dependencies for the integration test are installed (i.e. modified lock files)
const updateCommandArgs = ['@angular/core', '--migrate-only', '--from', fromVersion,
'--to', toVersion, '--allow-dirty', '--skip-commits'];
'--to', toVersion, '--allow-dirty'];

// Print out the command that is used to run the migrations for easier debugging.
console.error(`Running "ng update ${updateCommandArgs.join(' ')}":`);
Expand Down
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Expand Up @@ -35,10 +35,10 @@
},
"// 1": "dependencies are used locally and by bazel",
"dependencies": {
"@angular-devkit/architect": "^0.900.0-rc.0",
"@angular-devkit/build-optimizer": "^0.900.0-rc.0",
"@angular-devkit/core": "^9.0.0-rc.0",
"@angular-devkit/schematics": "^9.0.0-rc.0",
"@angular-devkit/architect": "^0.900.0-rc.3",
"@angular-devkit/build-optimizer": "^0.900.0-rc.3",
"@angular-devkit/core": "^9.0.0-rc.3",
"@angular-devkit/schematics": "^9.0.0-rc.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it seems that @schematics/angular hasn't been updated for a long time as it's still on 8.0.0-beta.15. Can you please update it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"@angular/bazel": "file:./tools/npm/@angular_bazel",
"@babel/core": "^7.6.4",
"@bazel/jasmine": "0.40.0",
Expand All @@ -48,7 +48,7 @@
"@bazel/terser": "0.40.0",
"@bazel/typescript": "0.40.0",
"@microsoft/api-extractor": "^7.3.9",
"@schematics/angular": "^8.0.0-beta.15",
"@schematics/angular": "^9.0.0-rc.3",
"@types/angular": "^1.6.47",
"@types/babel__core": "^7.1.3",
"@types/base64-js": "1.2.5",
Expand Down Expand Up @@ -128,7 +128,7 @@
"// 2": "devDependencies are not used under Bazel. Many can be removed after test.sh is deleted.",
"// 3": "when updating @bazel/bazel version you also need to update the RBE settings in .bazelrc (see https://github.com/angular/angular/pull/27935)",
"devDependencies": {
"@angular/cli": "^9.0.0-rc.0",
"@angular/cli": "^9.0.0-rc.3",
"@bazel/bazel": "1.1.0",
"@bazel/buildifier": "^0.29.0",
"@bazel/ibazel": "^0.10.3",
Expand Down