New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update to Angular CLI 9.0.0-rc.3 #33955
Conversation
You can preview 9ef6be5 at https://pr33955-9ef6be5.ngbuilds.io/. |
9ef6be5
to
197d758
Compare
You can preview 197d758 at https://pr33955-197d758.ngbuilds.io/. |
197d758
to
b052906
Compare
You can preview b052906 at https://pr33955-b052906.ngbuilds.io/. |
"@angular-devkit/architect": "^0.900.0-rc.3", | ||
"@angular-devkit/build-optimizer": "^0.900.0-rc.3", | ||
"@angular-devkit/core": "^9.0.0-rc.3", | ||
"@angular-devkit/schematics": "^9.0.0-rc.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it seems that @schematics/angular
hasn't been updated for a long time as it's still on 8.0.0-beta.15
. Can you please update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
You can preview 3bfeee4 at https://pr33955-3bfeee4.ngbuilds.io/. |
@@ -12,7 +12,7 @@ | |||
"master": { | |||
"uncompressed": { | |||
"runtime-es2015": 2987, | |||
"main-es2015": 506857, | |||
"main-es2015": 464734, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context:
This was temporarily changed from 461159
to 506857
(pending a cli release) in 08a4f10.
So, there seems to be 3.5KB regression ( EDIT: Not true. 👇461159
--> 464734
) from rc.1 to rc.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to say actually. It's true that the commit you linked changed the value. But that wasn't the absolute value, it was a value within +-1% of the real value.
Which is to say, I could have put that value and it would have still passed the CI. To know if there's a regression or not we'd need to check the sizes of FW+CLI rc.2 and FW+CLI rc.3 for AIO.
It's unfortunate that we can't vary just one. Next time we do this sort of coordinated change we should instead leave one of the packages (either FW or CLI) in a intermediate compat mode (@clydin suggested this approach for the change in question, but we ended up not going with it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Moreover, this size is for building with the local packages (so neither rc.1 nor rc.3) 😁
So, my comment was invalid 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did both builds:
- FW+CLI rc.2: 464103
- FW+CLI rc.3: 464814
So yes, there was a change of 701 bytes. I don't know if it was CLI or the FW though.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Followup to #33337 and angular/angular-cli#16228
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information