Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(compiler): Add back tests for renamed inputs and outputs #38798

Closed
wants to merge 1 commit into from
Closed

test(compiler): Add back tests for renamed inputs and outputs #38798

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Sep 10, 2020

#38685 corrected the confusion between field and property names so the consumer can
now be determined correctly.

@atscott
test(compiler): Add back tests for renamed inputs and outputs
5979012 
angular#38685 corrected the confusion between field and property names so the consumer can
now be determined correctly.
@atscott atscott added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: compiler Issues related to `ngc`, Angular's template compiler labels Sep 10, 2020
@atscott atscott requested a review from alxhub September 10, 2020 20:30
@ngbot ngbot bot modified the milestone: needsTriage Sep 10, 2020
AndrewKushnir
AndrewKushnir approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 10, 2020
@AndrewKushnir AndrewKushnir removed the request for review from alxhub September 10, 2020 21:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atscott @AndrewKushnir @googlebot