Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(compiler): Add back tests for renamed inputs and outputs #38798

Closed
wants to merge 1 commit into from
Closed

test(compiler): Add back tests for renamed inputs and outputs #38798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 8 additions & 10 deletions ...s/compiler-cli/src/ngtsc/typecheck/test/type_checker__get_symbol_of_template_node_spec.ts
View file
Open in desktop
Expand Up @@ -690,11 +690,10 @@ runInEachFileSystem(() => {

const inputBbinding = (nodes[0] as TmplAstElement).inputs[1];
const bSymbol = templateTypeChecker.getSymbolOfNode(inputBbinding, cmp)!;
// TODO(atscott): The BoundTarget is not assigning renamed properties correctly
// assertInputBindingSymbol(bSymbol);
// expect((bSymbol.bindings[0].tsSymbol!.declarations[0] as ts.PropertyDeclaration)
// .name.getText())
// .toEqual('inputB');
assertInputBindingSymbol(bSymbol);
expect((bSymbol.bindings[0].tsSymbol!.declarations[0] as ts.PropertyDeclaration)
.name.getText())
.toEqual('inputB');
});

it('does not retrieve a symbol for an input when undeclared', () => {
Expand Down Expand Up @@ -983,11 +982,10 @@ runInEachFileSystem(() => {

const outputBBinding = (nodes[0] as TmplAstElement).outputs[1];
const bSymbol = templateTypeChecker.getSymbolOfNode(outputBBinding, cmp)!;
// TODO(atscott): The BoundTarget is not assigning renamed properties correctly
// assertOutputBindingSymbol(bSymbol);
// expect((bSymbol.bindings[0].tsSymbol!.declarations[0] as ts.PropertyDeclaration)
// .name.getText())
// .toEqual('outputB');
assertOutputBindingSymbol(bSymbol);
expect((bSymbol.bindings[0].tsSymbol!.declarations[0] as ts.PropertyDeclaration)
.name.getText())
.toEqual('outputB');
});

it('should find symbol for output binding when there are multiple directives', () => {
Expand Down