Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router standalone directives #46758

Closed
wants to merge 1 commit into from
Closed

Router standalone directives #46758

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Jul 8, 2022

See individual commits

@ngbot ngbot bot added this to the Backlog milestone Jul 8, 2022
@atscott atscott force-pushed the routerStandaloneDirectives branch 7 times, most recently from 5304cf4 to c236d03 Compare July 13, 2022 16:53
@atscott atscott mentioned this pull request Jul 13, 2022
Closed
@atscott atscott force-pushed the routerStandaloneDirectives branch 3 times, most recently from 1cfa424 to 32d4682 Compare July 13, 2022 19:28
@atscott atscott added feature Issue that requests a new feature target: minor This PR is targeted for the next minor release labels Jul 13, 2022
@atscott atscott force-pushed the routerStandaloneDirectives branch from 32d4682 to 259efe2 Compare July 13, 2022 19:52
@atscott
Copy link
Contributor Author

atscott commented Jul 13, 2022

presubmit

@atscott atscott marked this pull request as ready for review July 13, 2022 22:17
jessicajaniuk
jessicajaniuk approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from alxhub July 13, 2022 22:43
@atscott atscott force-pushed the routerStandaloneDirectives branch 2 times, most recently from c68999e to d532054 Compare July 14, 2022 18:04
@atscott
feat(router): Make router directives standalone
ebabd20 
This commit makes the router directives standalone and refactors some of
the Router injectables to be `providedIn: 'root'` along with factory
functions for initialization.
@atscott atscott force-pushed the routerStandaloneDirectives branch from d532054 to ebabd20 Compare July 14, 2022 18:52
@atscott
Copy link
Contributor Author

atscott commented Jul 14, 2022

TGP after some fixes. Should run regular presubmit as a sanity check

AndrewKushnir
AndrewKushnir approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api, size-tracking

@atscott
Copy link
Contributor Author

atscott commented Jul 14, 2022

sanity presubmit

@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Jul 14, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 26ea976.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: router feature Issue that requests a new feature target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atscott @jessicajaniuk @AndrewKushnir