fix(router): Ensure ActivatedRouteSnapshot#title has correct value #47481
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActivatedRouteSnapshot data gets mutated in the resolve phase of the Router. The title is assigned as part of this. As a result, the title must be a getter in order to pick up the value that was note available during the class creation. fixes angular#47459 BREAKING CHANGE: The title property is now required on ActivatedRouteSnapshot
atscott
added
breaking changes
target: major
pullapprove
bot
requested review from
AndrewKushnir,
jessicajaniuk and
pkozlowski-opensource
jessicajaniuk
approved these changes
Sep 19, 2022
AndrewKushnir
approved these changes
Sep 19, 2022
AndrewKushnir
approved these changes
Sep 19, 2022
pkozlowski-opensource
approved these changes
Sep 23, 2022
pkozlowski-opensource
approved these changes
Sep 23, 2022
|
@atscott this PR got all the approvals but it seems like it needs a bit more work before it can land: g3 status is "failing" and I'm not sure if this is a flake or something that needs attention. Also, since this is a breaking change, it should go to one of the v15 milestones, right? |
atscott
modified the milestones:
Backlog,
v15 feature freeze blockers,
v15 final blockers
|
@pkozlowski-opensource That's right. There is some remaining cleanup in g3 that is ongoing. |
|
TGP with internal cleanups |
|
This PR was merged into the repository by commit 6a88bad. |
dylhunn
pushed a commit
to dylhunn/angular
that referenced
this pull request
Sep 27, 2022
…ngular#47481) ActivatedRouteSnapshot data gets mutated in the resolve phase of the Router. The title is assigned as part of this. As a result, the title must be a getter in order to pick up the value that was note available during the class creation. fixes angular#47459 BREAKING CHANGE: The title property is now required on ActivatedRouteSnapshot PR Close angular#47481
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActivatedRouteSnapshot data gets mutated in the resolve phase of the Router. The title is assigned as part of this. As a result, the title must be a getter in order to pick up the value that was note available during the class creation.
fixes #47459
BREAKING CHANGE: The title property is now required on ActivatedRouteSnapshot