Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): Ensure ActivatedRouteSnapshot#title has correct value #47481

Closed
wants to merge 1 commit into from
Closed

fix(router): Ensure ActivatedRouteSnapshot#title has correct value #47481

wants to merge 1 commit into from
+19 −3

Commits on Sep 19, 2022

  1. fix(router): Ensure ActivatedRouteSnapshot#title has correct value 

    ActivatedRouteSnapshot data gets mutated in the resolve phase of the Router. The title is assigned as part of this.
As a result, the title must be a getter in order to pick up the value that was note available during the class creation.

fixes angular#47459

BREAKING CHANGE: The title property is now required on ActivatedRouteSnapshot
    @atscott
    atscott committed Sep 19, 2022
    Copy the full SHA
    95e6302 View commit details
    Browse the repository at this point in the history