Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-cli): support hasInvalidatedResolutions. #47585

Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): support hasInvalidatedResolutions. #47585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/compiler-cli/src/ngtsc/core/src/host.ts
View file
Open in desktop
Expand Up @@ -68,6 +68,11 @@ export class DelegatingCompilerHost implements
useCaseSensitiveFileNames = this.delegateMethod('useCaseSensitiveFileNames');
writeFile = this.delegateMethod('writeFile');
getModuleResolutionCache = this.delegateMethod('getModuleResolutionCache');
// @ts-expect-error 'hasInvalidatedResolutions' is visible (and thus required here) in latest TSC
// main. It's already present, so the code works at runtime.
// TODO: remove this comment including the suppression once Angular uses a TSC version that
mprobst marked this conversation as resolved.
Show resolved Hide resolved
// includes this change (github.com/microsoft/TypeScript@a455955).
hasInvalidatedResolutions = this.delegateMethod('hasInvalidatedResolutions');
crisbeto marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down
5 changes: 5 additions & 0 deletions packages/compiler-cli/src/ngtsc/program_driver/src/ts_create_program_driver.ts
View file
Open in desktop
Expand Up @@ -52,6 +52,11 @@ export class DelegatingCompilerHost implements
trace = this.delegateMethod('trace');
useCaseSensitiveFileNames = this.delegateMethod('useCaseSensitiveFileNames');
getModuleResolutionCache = this.delegateMethod('getModuleResolutionCache');
// @ts-expect-error 'hasInvalidatedResolutions' is visible (and thus required here) in latest TSC
// main. It's already present, so the code works at runtime.
// TODO: remove this comment including the suppression once Angular uses a TSC version that
// includes this change (github.com/microsoft/TypeScript@a455955).
hasInvalidatedResolutions = this.delegateMethod('hasInvalidatedResolutions');
}

/**
Expand Down