fix(compiler-cli): support hasInvalidatedResolutions. #47585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Sep 29, 2022
|
@crisbeto @atscott can you help me with the test failure? Here's the error log: That sounds like it's very unlikely to be caused by my change? |
|
That's just a flaky test. I've restarted it. |
crisbeto
approved these changes
Oct 4, 2022
crisbeto
added
action: review
atscott
approved these changes
Oct 4, 2022
The latest TypeScript compiler exposes the previously private field `hasInvalidatedResolutions`. That breaks Angular in the newer TS, because the new field would be required on DelegatingCompilerHost. However we cannot just add the field here, because it's not present in the older compiler. This change adds the field for delegation, which works at runtime because the field is present. It suppresses the compiler error using a `// @ts-expect-error`, which should be removed once Angular moves to a TSC version that includes this change.
atscott
added
action: merge
AndrewKushnir
added
the
action: presubmit
atscott
approved these changes
Oct 4, 2022
crisbeto
approved these changes
Oct 4, 2022
|
This PR was merged into the repository by commit 2e1ddde. |
4 tasks
yharaskrik
pushed a commit
to yharaskrik/angular
that referenced
this pull request
Oct 5, 2022
The latest TypeScript compiler exposes the previously private field `hasInvalidatedResolutions`. That breaks Angular in the newer TS, because the new field would be required on DelegatingCompilerHost. However we cannot just add the field here, because it's not present in the older compiler. This change adds the field for delegation, which works at runtime because the field is present. It suppresses the compiler error using a `// @ts-expect-error`, which should be removed once Angular moves to a TSC version that includes this change. PR Close angular#47585
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest TypeScript compiler exposes the previously private field
hasInvalidatedResolutions. That breaks Angular in the newer TS, because the new field would be required on DelegatingCompilerHost. However we cannot just add the field here, because it's not present in the older compiler.This change adds the field for delegation, which works at runtime because the field is present. It suppresses the compiler error using a
// @ts-expect-error, which should be removed once Angular moves to a TSC version that includes this change.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Doesn't compile with the latest tsc.
Issue Number: N/A
What is the new behavior?
Compiles with the latest tsc.
Does this PR introduce a breaking change?