feat(router): migrate RouterLinkWithHref references to RouterLink

[AndrewKushnir]

Since Angular v15, the RouterLink contains the logic of the RouterLinkWithHref directive and now developers can always import and use the RouterLink directive when they need to add a [routerLink] in templates. This migration finds all imports and usages of the RouterLinkWithHref class and rewrites them to RouterLink instead.

import { RouterLinkWithHref } from '@angular/router';

@Component({
  standalone: true,
  template: `<a [routerLink]="'/abc'">`,
  imports: [RouterLinkWithHref]
})
export class MyComponent {
  @ViewChild(RouterLinkWithHref) aLink!: RouterLinkWithHref;
}

import { RouterLink } from '@angular/router';

@Component({
  standalone: true,
  template: `<a [routerLink]="'/abc'">`,
  imports: [RouterLink]
})
export class MyComponent {
  @ViewChild(RouterLink) aLink!: RouterLink;
}

PR Type

What kind of change does this PR introduce?

• Feature

Does this PR introduce a breaking change?

• Yes
• No

[crisbeto]

LGTM

[AndrewKushnir]

@crisbeto thanks for the review 👍

I've actually rewrote the logic a bit taking into account your comment. Now the process looks like this:

• we find all usages and imports, store them in an array (as start pos, width of the symbol and a replacement)
• sort by start pos in descending order (last-to-first usages) to avoid offset shifts
• once all usages are collected and sorted, we apply rewrites

Previously, lookups (to find usages) and rewrites were interleaved, thus susceptible to offset shifts.

Could you please take another look when you get a chance?

[crisbeto]

LGTM

[AndrewKushnir]

Presubmit.

[jessicajaniuk]

This PR was merged into the repository by commit 16c8f55.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}