New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-cli): use @ts-ignore. #47636
Conversation
The previous commit 2e1ddde used `@ts-expect-error` to suppress the current error, with the intent of being informed once that's no longer an error, ie. when we updated to an upstream TS version that includes this change. However this unfortunately means the change is incompatible with the fixed version, which prevents it from working with an updated TS version in google3. This change reverts back to the original `@ts-ignore` which is forwards and backwards compatible, avoiding that problem (but unfortunately losing the benefit of being notified once fixed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge-assistance: the size test failure is unrelated and likely a flake. This PR is ready for merge. |
This PR was merged into the repository by commit 19ad498. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The previous commit 2e1ddde used
@ts-expect-error
to suppress the current error, with the intent of being informed once that's no longer an error, ie. when we updated to an upstream TS version that includes this change.However this unfortunately means the change is incompatible with the fixed version, which prevents it from working with an updated TS version in google3.
This change reverts back to the original
@ts-ignore
which is forwards and backwards compatible, avoiding that problem (but unfortunately losing the benefit of being notified once fixed).This is a follow up to PR #47585.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
See above.
Does this PR introduce a breaking change?