Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-cli): use @ts-ignore. #47636

Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): use @ts-ignore. #47636

wants to merge 1 commit into from

Commits on Oct 5, 2022

  1. fix(compiler-cli): use @ts-ignore. 

    The previous commit 2e1ddde used `@ts-expect-error` to suppress the
current error, with the intent of being informed once that's no longer
an error, ie. when we updated to an upstream TS version that includes
this change.

However this unfortunately means the change is incompatible with the
fixed version, which prevents it from working with an updated TS version
in google3.

This change reverts back to the original `@ts-ignore` which is forwards
and backwards compatible, avoiding that problem (but unfortunately
losing the benefit of being notified once fixed).
    @mprobst
    mprobst committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e5a20e9 View commit details
    Browse the repository at this point in the history