Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add support for Node.js version 18 #47730

Closed
wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Oct 11, 2022

This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports Node.js versions 14.[15-19].x and 16.[10-12].x. Current supported versions of Node.js are 14.20.x, 16.13.x and 18.10.x.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 11, 2022
@angular-robot angular-robot bot added flag: breaking change feature Issue that requests a new feature labels Oct 11, 2022
@alan-agius4 alan-agius4 force-pushed the node-support branch 2 times, most recently from f76dcd2 to f42e9e6 Compare October 11, 2022 11:41
@ngbot ngbot bot removed this from the v15 feature freeze blockers milestone Oct 11, 2022
@alan-agius4 alan-agius4 marked this pull request as ready for review October 11, 2022 11:42
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 11, 2022
@alan-agius4 alan-agius4 requested review from josephperrott and removed request for alxhub, devversion and AndrewKushnir October 11, 2022 11:42
@ngbot ngbot bot removed this from the v15 feature freeze blockers milestone Oct 11, 2022
@alan-agius4 alan-agius4 changed the title feat(core): add support for Node.js version 19 feat(core): add support for Node.js version 18 Oct 11, 2022
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
@jessicajaniuk jessicajaniuk added the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 11, 2022
@ngbot ngbot bot added this to the Backlog milestone Oct 11, 2022
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-approvers

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 11, 2022
@jessicajaniuk jessicajaniuk removed the request for review from alxhub October 11, 2022 16:56
@jessicajaniuk jessicajaniuk removed the request for review from AndrewKushnir October 11, 2022 16:56
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 1b9fd46.

@alan-agius4 alan-agius4 deleted the node-support branch October 11, 2022 17:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler feature Issue that requests a new feature target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants