fix(router): Ensure renavigating in component init works with enabled… #48066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
previously approved these changes
Nov 15, 2022
…Blocking The way to complete the `Subject` in a way that is able to be read on the subject properties itself is to call `unsubscribe`: https://github.com/ReactiveX/rxjs/blob/afac3d574323333572987e043adcd0f8d4cff546/src/internal/Subject.ts#L101-L104 This sets the `closed` property to `true` whereas `complete` does not. fixes angular#48052
atscott
force-pushed
the
v14targetfix
branch
from
0b92918
to
c6acf92
Compare
AndrewKushnir
approved these changes
Nov 15, 2022
atscott
added
action: merge
|
caretaker note: This is a patch-only PR and cannot run google internal tests with it |
|
This PR was merged into the repository by commit aef353c. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 15, 2022
…Blocking (#48066) The way to complete the `Subject` in a way that is able to be read on the subject properties itself is to call `unsubscribe`: https://github.com/ReactiveX/rxjs/blob/afac3d574323333572987e043adcd0f8d4cff546/src/internal/Subject.ts#L101-L104 This sets the `closed` property to `true` whereas `complete` does not. fixes #48052 PR Close #48066
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Nov 21, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.10` -> `14.2.11`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.10/14.2.11) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.10` -> `14.2.11`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.10/14.2.11) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.10` -> `14.2.11`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.10/14.2.11) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.10` -> `14.2.11`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.10/14.2.11) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.10` -> `14.2.11`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.10/14.2.11) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.10` -> `14.2.11`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.10/14.2.11) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.10` -> `14.2.11`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.10/14.2.11) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.10` -> `14.2.11`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.10/14.2.11) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.11`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​14211-2022-11-16) [Compare Source](angular/angular@14.2.10...14.2.11) ##### router | Commit | Type | Description | | -- | -- | -- | | [aef353c143](angular/angular@aef353c) | fix | Ensure renavigating in component init works with enabledBlocking ([#​48066](angular/angular#48066)) | #### Special Thanks Alan Agius, Andrew Scott and Mujo Osmanovic <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNS4xIiwidXBkYXRlZEluVmVyIjoiMzQuMjcuMSJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1644 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Blocking
The way to complete the
Subjectin a way that is able to be read on the subject properties itself is to callunsubscribe: https://github.com/ReactiveX/rxjs/blob/afac3d574323333572987e043adcd0f8d4cff546/src/internal/Subject.ts#L101-L104 This sets theclosedproperty totruewhereascompletedoes not.fixes #48052