Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): Ensure renavigating in component init works with enabled… #48066

Closed
wants to merge 1 commit into from
Closed

fix(router): Ensure renavigating in component init works with enabled… #48066

wants to merge 1 commit into from

Commits on Nov 15, 2022

  1. fix(router): Ensure renavigating in component init works with enabled… 

    …Blocking

The way to complete the `Subject` in a way that is able to be read on
the subject properties itself is to call `unsubscribe`:
https://github.com/ReactiveX/rxjs/blob/afac3d574323333572987e043adcd0f8d4cff546/src/internal/Subject.ts#L101-L104
This sets the `closed` property to `true` whereas `complete` does not.

fixes angular#48052
    @atscott
    atscott committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c6acf92 View commit details
    Browse the repository at this point in the history