Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): update packages/language-service/build.sh script to work with vscode-ng-language-service's new Bazel build #48120

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Nov 18, 2022

Part of fix for angular/vscode-ng-language-service#1815

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregmagolan gregmagolan changed the title fix(language-service): update packages/language-service/build.sh script to work with vscode-ng-language-service's new Bazel build fix(language-service): update packages/language-service/build.sh script Nov 18, 2022
@gregmagolan gregmagolan force-pushed the fix_local_built_language_service_vscode_repo_flow branch from 13a82d6 to 83651f9 Compare November 18, 2022 17:20
@gregmagolan gregmagolan changed the title fix(language-service): update packages/language-service/build.sh script fix(language-service): update packages/language-service/build.sh script to work with vscode-ng-language-service's new Bazel build Nov 18, 2022
…pt to work with vscode-ng-language-service's new Bazel build

Part of fix for angular/vscode-ng-language-service#1815
@gregmagolan gregmagolan force-pushed the fix_local_built_language_service_vscode_repo_flow branch from 83651f9 to 53163be Compare November 18, 2022 17:21
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 18, 2022
@dylhunn dylhunn self-requested a review November 18, 2022 18:21
@dylhunn
Copy link
Contributor

dylhunn commented Nov 18, 2022

This PR was merged into the repository by commit 764fa3d.

dylhunn pushed a commit that referenced this pull request Nov 18, 2022
…pt to work with vscode-ng-language-service's new Bazel build (#48120)

Part of fix for angular/vscode-ng-language-service#1815

PR Close #48120
@dylhunn dylhunn closed this in 764fa3d Nov 18, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2022
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
…pt to work with vscode-ng-language-service's new Bazel build (angular#48120)

Part of fix for angular/vscode-ng-language-service#1815

PR Close angular#48120
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants